Opened 8 years ago

Last modified 8 years ago

#5296 new Bug

Reporting finished download before hash check completed.

Reported by: popman Owned by: jordan
Priority: Normal Milestone: None Set
Component: libtransmission Version: 2.76
Severity: Minor Keywords:
Cc:

Description

Transmission reports completing the download when the amount of data not confirmed corrupt is equal to the file size. (only tested in the Mac client, but it's probably a deeper issue)

The hash check is still done, but if the final few downloaded pieces are corrupt it will take as long as a few minutes for the count to be revised down from 100%

This causes big issues of file corruption, since a completion can call a script, which, for instance, immediately copy the file and mark it for deletion.

Change History (3)

comment:1 Changed 8 years ago by livings124

  • Component changed from Mac Client to libtransmission
  • Owner changed from livings124 to jordan

comment:2 follow-up: Changed 8 years ago by freebourg

Thanks for reporting the issue.

This is a bit tricky because some people do want to run a script even if hash check failed. So we have many options here: 1) delay script after hash check and run it only if hash check succeeded 2) mark download as finished after hash check 3) add a new option to run a script after hash check 4) ...

I suggest option 3 as this would not change transmission behaviour and is more flexible.

comment:3 in reply to: ↑ 2 Changed 8 years ago by popman

Replying to freebourg:

Thanks for reporting the issue.

This is a bit tricky because some people do want to run a script even if hash check failed. So we have many options here: 1) delay script after hash check and run it only if hash check succeeded 2) mark download as finished after hash check 3) add a new option to run a script after hash check 4) ...

I suggest option 3 as this would not change transmission behaviour and is more flexible.

Every time I have had this bug occur, the final downloaded piece is not hash checked by transmission.

Note: See TracTickets for help on using tickets.