Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#5312 closed Bug (fixed)

Download check box toggle with spacebar is broken

Reported by: Self-Perfection Owned by: mike.dld
Priority: Normal Milestone: 2.83
Component: Qt Client Version: 2.80
Severity: Normal Keywords: backport-2.8x
Cc: sterkrig@…

Description

Imagine torrent with files "file00" - "file99". And user wants to download only "file50" - "file99".

In 2.77 following trick works: 1) Click "file00" 2) Shift + click "file49" to select first fifty files 3) Hit spacebar to clear download checkboxes for this files

In latest SVN (14038) this use case is broken: spacebar does not toggle checkbox state.

Attachments (1)

5312-handle-special-keys-in-file-tree-view.patch (993 bytes) - added by mike.dld 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by rb07

The spacebar and Enter keyboard functions where disabled because they interfere with name editing (i.e. the selection and the priority change if you hit space or Enter while editing).

See ticket comment https://trac.transmissionbt.com/ticket/5252#comment:4

comment:2 Changed 8 years ago by krigstask

  • Cc sterkrig@… added

IMHO, toggling file status from keyboard are far more common than editing file names. And, of course, new features shouldn't break old ones. If there's no way to disable file toggling upon pressing spacebar when editing file name, at least bring another key like Shift+Space to do that.

comment:3 Changed 8 years ago by jordan

  • Version changed from 2.77+ to 2.80

comment:4 Changed 8 years ago by mike.dld

  • Keywords patch added
  • Owner changed from jordan to mike.dld
  • Status changed from new to assigned

Attaching patch which does the job. Please comment. Short note: I brought previously removed code back but added a check for view not being in editing state.

comment:5 Changed 8 years ago by jordan

  • Keywords backport-2.8x added; patch removed
  • Milestone changed from None Set to 2.90

Looks good to me...

comment:6 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Added r14197

comment:7 Changed 7 years ago by livings124

  • Milestone changed from 2.90 to 2.83
Note: See TracTickets for help on using tickets.