Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5427 closed Bug (fixed)

torrents start in pause

Reported by: dagra22 Owned by:
Priority: Normal Milestone: 2.83
Component: libtransmission Version: 2.82
Severity: Normal Keywords: backport-2.8x
Cc:

Description

hello , i have my transmission settings in a way that only download a torrent at time when other torrent need enter in the queue till the current download finish now the thing is sometime i close transmission and start it again later and go to do something else some where and when i come back and check my torrents i see that only the torrent that was still downloading when i left is finish and the other in the queue are in pause, so the problem is that torrent don't get start in "waiting mode/queue" instead of pause

thanks

transmission version2.80 (14103) os : GNU/Linux distro Archlinux

Attachments (4)

002-resume-queued.patch (446 bytes) - added by rb07 8 years ago.
que_restart.diff (1.3 KB) - added by cfpp2p 8 years ago.
que_restart-v2.diff (1.5 KB) - added by cfpp2p 8 years ago.
que_restart_v2.diff (1.5 KB) - added by cfpp2p 8 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by rb07

comment:1 Changed 8 years ago by rb07

I've been using the one line fix attached for a long time.

To be clear (unlike most reports about the queue), this fixes the queued torrents turning into paused after restart; it doesn't fix the queue order (which is lost after restart), or the queue going 'backwards' (LIFO instead of FIFO).

Related tickets: #4540, #4484, #5419 etc.

comment:2 Changed 8 years ago by jordan

  • Component changed from Transmission to libtransmission
  • Milestone changed from None Set to 2.82
  • Resolution set to fixed
  • Status changed from new to closed

I've committed this one-liner in r14136.

comment:3 Changed 8 years ago by dagra22

thanks a lot !

Changed 8 years ago by cfpp2p

comment:4 Changed 8 years ago by cfpp2p

  • Milestone changed from 2.82 to None Set
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from 2.80 to 2.82+

With r14136 I did not see consistently torrents starting in "waiting mode/queue" instead of pause after a restart. Frequently queued torrents still ended up paused. Attached patch que_restart.diff fixes this for me. This still does not fix the queue order after a restart.

There is a very slight change in the patch I attach now (moderated, should show up soon) que_restart-v2.diff which got confused in the original moderation process. Here is the additional change.

resume.c


@@ -778,7 +778,7 @@
   if ((fieldsToLoad & TR_FR_RUN)
       && tr_variantDictFindBool (&top, TR_KEY_paused, &boolVal))
     {
-      tor->isRunning = !boolVal && !tor->isQueued; 
+      tor->isRunning = !boolVal; 
       fieldsLoaded |= TR_FR_RUN;

Last edited 8 years ago by cfpp2p (previous) (diff)

Changed 8 years ago by cfpp2p

Changed 8 years ago by cfpp2p

comment:5 Changed 8 years ago by jordan

  • Keywords backport-2.8x added
  • Milestone changed from None Set to 2.90
  • Version changed from 2.82+ to 2.82

comment:6 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

que_restart_v2.diff added in r14208. Thanks!

comment:7 Changed 8 years ago by livings124

  • Milestone changed from 2.90 to 2.83
Note: See TracTickets for help on using tickets.