Opened 14 years ago

Closed 14 years ago

#550 closed Enhancement (invalid)

Improvements to the new progress bar

Reported by: infernux Owned by: charles
Priority: Normal Milestone: None Set
Component: GTK+ Client Version: 0.96
Severity: Normal Keywords:
Cc:

Description

The way torrents show up now is great! There are a few things with the new progress bar that could be even better, though:

On the right side, the bar seems to have one pixel row that is drawn transparent (uses the selection color if torrent is selected)

What exactly do the colors of the bar mean? Blue=Done, Yellow=Downloading, LightGray?=ToDownload?, DarkGray?=NotToDownload?, Red=stalled? It would be nice to have this explained in the help menu somehow.

Could Tango colors¹ be used here? Because of the nice gradient that is used, you can also simply use variations of the tango palette (make colors darker/lighter) if you don't want to use the predefined colors. Just having the colors a bit more tangoish would look great.

[1] http://tango-project.org/static/cvs/tango-art-tools/palettes/Tango-Palette.png

Attachments (5)

Screenshot.png (569 bytes) - added by infernux 14 years ago.
End of progress bar look
Screenshot-1.png (2.6 KB) - added by infernux 14 years ago.
Problems with other gtk themes? (Here: Crux theme)
tr-tango.diff (1.6 KB) - added by infernux 14 years ago.
Patch, incomplete
tr.png (88.8 KB) - added by infernux 14 years ago.
Color comparison sheet (old/new)
tr-tango-2.diff (1.6 KB) - added by infernux 14 years ago.
Complete patch using the colors above

Download all attachments as: .zip

Change History (14)

Changed 14 years ago by infernux

End of progress bar look

Changed 14 years ago by infernux

Problems with other gtk themes? (Here: Crux theme)

comment:1 Changed 14 years ago by infernux

The first issue I mentioned has been fixed I thinke, thanks.

comment:2 Changed 14 years ago by infernux

I was too fast... the first issue still occurs, but not for any torrent...

comment:3 Changed 14 years ago by charles

  • Milestone changed from None Set to 1.10

comment:4 Changed 14 years ago by charles

  • Type changed from Bug to Enhancement

comment:5 Changed 14 years ago by charles

infernux - could you make a patch for the tango colors? the colors are defined at the top of torrent-cell-renderer.c

Changed 14 years ago by infernux

Patch, incomplete

comment:6 Changed 14 years ago by infernux

The patch replaces all the color with close tango palette matches. I did not change the grays yet... IMHO it is bad to use nearly the same color for missing, unwanted and paused. Well, I don't even think many users will ever know what those colors mean, but we have other colors left (like purple, orange and brown), perhaps using gray for paused and orange/brown for missing/unwanted would work?

Changed 14 years ago by infernux

Color comparison sheet (old/new)

Changed 14 years ago by infernux

Complete patch using the colors above

comment:7 Changed 14 years ago by infernux

This looks very nice. IMHO having "Missing" not being gray helps a lot to get the right idea about its meaning. Perhaps swapping the colors of "verifying" and "missing" would make sense, though. Using brown for "verifying" and yellow for "missing" would be another possibility.

comment:8 Changed 14 years ago by charles

1.0x: r4963 trunk: r4964

comment:9 Changed 14 years ago by charles

  • Milestone changed from 1.10 to None Set
  • Resolution set to invalid
  • Status changed from new to closed

The rest of these issues are moot now that we're using the native progressbar.

Note: See TracTickets for help on using tickets.