Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5500 closed Bug (fixed)

Compatiblity to SPDY Proxies: Do not send empty header

Reported by: Danez Owned by: jordan
Priority: Low Milestone: 2.83
Component: Web Client Version: 2.82
Severity: Normal Keywords: backport-2.8x spdy
Cc:

Description

Currently the webclient sends an empty header on its first request:

...
X-Transmission-Session-Id: 
...

Sending an empty header is not valid for the SPDY/2 Protocol. It is valid for SPDY/3 again, but nginx only supports version 2 right now. (see https://groups.google.com/forum/#!topic/spdy-dev/hfRqjyeSGyA)

I created a small patch that creates compatibility to spdy/2.

Would love to see that in the next version.

Attachments (1)

spdy_patch.patch (451 bytes) - added by Danez 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Danez

comment:1 Changed 8 years ago by LinusU

Shouldn't you put an if around the setRequestHeader rather then setting the value to zero?

comment:2 Changed 8 years ago by jordan

  • Keywords backport-2.8x added
  • Milestone changed from None Set to 2.90
  • Owner set to jordan
  • Status changed from new to assigned

comment:3 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r14207. Thanks for the suggestion!

comment:4 Changed 8 years ago by livings124

  • Milestone changed from 2.90 to 2.83
Note: See TracTickets for help on using tickets.