Opened 7 years ago

Closed 7 years ago

#5570 closed Bug (fixed)

[REGRESSION] Peers no longer restored from resume file

Reported by: Nonal Owned by: jordan
Priority: Normal Milestone: 2.83
Component: Transmission Version: 2.82
Severity: Normal Keywords:
Cc:

Description

Hi,

Somewhere between 2.77 and 2.80 (during migration to quark.h file) restoration of saved peers from .resume file has been broken.

After investigation, it looks like loadPeers and savePeers (in resume.c) are using different enums to access to dictionary file. Probably some confusion between TR_KEY_peers/TR_KEY_peers6 (used in announcer-http.c), and TR_KEY_peers2/TR_KEY_peers2_6 (in resume.c)

Attached patch has been tested on HEAD and 2.80.

Thanks,

Attachments (1)

restore_peers_from_resume.patch (829 bytes) - added by Nonal 7 years ago.
Proposed patch against HEAD

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Nonal

Proposed patch against HEAD

comment:1 Changed 7 years ago by jordan

  • Milestone changed from None Set to 2.83
  • Owner set to jordan
  • Status changed from new to assigned

Nice catch. Thanks!

comment:2 Changed 7 years ago by jordan

Patch added to trunk in r14228.

comment:3 Changed 7 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.