Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#5692 closed Bug (fixed)

Quota support for Cygwin

Reported by: rb07 Owned by: jordan
Priority: Normal Milestone: 2.90
Component: libtransmission Version: 2.83
Severity: Normal Keywords:


This change, needed to build under Cygwin(*), got lost somehow:

Index: libtransmission/platform-quota.c
diff --git a/trunk/libtransmission/platform-quota.c b/trunk/libtransmission/platform-quota.c
--- a/trunk/libtransmission/platform-quota.c    (revision 14283)
+++ b/trunk/libtransmission/platform-quota.c    (working copy)
@@ -284,7 +284,7 @@
       spaceused = (int64_t) dq.dqb_curbytes;
 #elif defined(__UCLIBC__)
       spaceused = (int64_t) btodb(dq.dqb_curblocks);
-#elif defined(__sun) || (_LINUX_QUOTA_VERSION < 2)
+#elif defined(__sun) || (defined(_LINUX_QUOTA_VERSION) && _LINUX_QUOTA_VERSION < 2)
       spaceused = (int64_t) dq.dqb_curblocks >> 1;
       spaceused = btodb(dq.dqb_curspace);

Cygwin added the <sys/quota.h> missing header after Transmission 2.82 was released (i.e. it didn't build before w/o manually adding the header), but its now present.

(*) Not the only change needed. Also "-ansi" needs to be deleted on third-party/libutp/Makefile (reported long ago to them).

Change History (3)

comment:1 Changed 9 years ago by jordan

  • Milestone changed from None Set to 2.90
  • Status changed from new to assigned

comment:2 Changed 8 years ago by mike.dld

  • Resolution set to fixed
  • Status changed from assigned to closed

Committed as r14373, thanks.

comment:3 Changed 8 years ago by mike.dld

Damn, commit message is not correct. I should sleep more I guess.

Note: See TracTickets for help on using tickets.