Add support for the BitTorrent "mainline client" peer-id

[torstehu]

Hi, from: ​http://forum.bittorrent.com/topic/28078-79-stable/

-BT791- BitTorrent? 7.9.1 -BT791B- BitTorrent? 7.9.1 (Beta)

would be great to get feedback if this isn't the right approach.

[jordan]

Added in r14286.

[cfpp2p]

It remains that I am still getting -BT791- Beta versions of the BitTorrent client are correctly resolved.

The code to support non beta versions should not be in the block:

/* Azureus-style */ if (id[0] == '-' && id[7] == '-')

since the final '-' is at id[6]

something like below placed in the /* Everything else */ block works for both the 7 character -BT791- and the 8 character -BT791B-

line 407

    else if (!memcmp (id, "-BT", 3))
    {
        tr_snprintf (buf, buflen, "BitTorrent %c.%c.%c%s", id[3], id[4], id[5],
        getMnemonicEnd (id[6]));
    }

clients-test maybe should include something like this:

TEST_CLIENT ("-BT791-", "BitTorrent 7.9.1");

[torstehu]

Spotted in the wild: -BT791-%00 and Bittorrent 7.9.2 (-BT7920-)

[cfpp2p]

Replying to torstehu:

Spotted in the wild: -BT791-%00 and Bittorrent 7.9.2 (-BT7920-)

proposed code of comment:3 is displaying Bittorrent 7.9.1 and Bittorrent 7.9.2 respectively

[jordan]

See also: ​https://github.com/rakshasa/libtorrent/issues/56

[jordan]

Since 7.9.2's gone back to using the standard peer-id format, I suspect the peer-id in 7.9.1 (stable) might have just been a bug.

IMO this doesn't need a code change in Transmission unless BT has another release that uses 7 characters in its peer-id.