Opened 8 years ago
Closed 8 years ago
#5711 closed Enhancement (fixed)
Add support for the BitTorrent "mainline client" peer-id
Reported by: | torstehu | Owned by: | jordan |
---|---|---|---|
Priority: | Normal | Milestone: | 2.90 |
Component: | libtransmission | Version: | 2.83 |
Severity: | Minor | Keywords: | |
Cc: |
Description
Hi, from: http://forum.bittorrent.com/topic/28078-79-stable/
-BT791- BitTorrent? 7.9.1 -BT791B- BitTorrent? 7.9.1 (Beta)
would be great to get feedback if this isn't the right approach.
Attachments (2)
Change History (9)
Changed 8 years ago by torstehu
Changed 8 years ago by torstehu
comment:1 Changed 8 years ago by jordan
- Milestone changed from None Set to 2.90
- Status changed from new to assigned
comment:2 Changed 8 years ago by jordan
- Resolution set to fixed
- Status changed from assigned to closed
- Summary changed from Add support for the new peer-ID scheme for mainline client to Add support for the BitTorrent "mainline client" peer-id
comment:3 Changed 8 years ago by cfpp2p
- Resolution fixed deleted
- Status changed from closed to reopened
It remains that I am still getting -BT791- Beta versions of the BitTorrent client are correctly resolved.
The code to support non beta versions should not be in the block:
/* Azureus-style */ if (id[0] == '-' && id[7] == '-')
since the final '-' is at id[6]
something like below placed in the /* Everything else */ block works for both the 7 character -BT791- and the 8 character -BT791B-
line 407
else if (!memcmp (id, "-BT", 3)) { tr_snprintf (buf, buflen, "BitTorrent %c.%c.%c%s", id[3], id[4], id[5], getMnemonicEnd (id[6])); }
clients-test maybe should include something like this:
TEST_CLIENT ("-BT791-", "BitTorrent 7.9.1");
comment:4 follow-up: ↓ 5 Changed 8 years ago by torstehu
Spotted in the wild: -BT791-%00 and Bittorrent 7.9.2 (-BT7920-)
comment:5 in reply to: ↑ 4 Changed 8 years ago by cfpp2p
comment:6 Changed 8 years ago by jordan
comment:7 Changed 8 years ago by jordan
- Resolution set to fixed
- Status changed from reopened to closed
Since 7.9.2's gone back to using the standard peer-id format, I suspect the peer-id in 7.9.1 (stable) might have just been a bug.
IMO this doesn't need a code change in Transmission unless BT has another release that uses 7 characters in its peer-id.
Added in r14286.