Opened 8 years ago

Closed 8 years ago

#5721 closed Enhancement (fixed)

Use built-in __APPLE__ macro instead of SYS_DARWIN and MACOSX

Reported by: mike.dld Owned by:
Priority: Normal Milestone: 2.90
Component: Transmission Version: 2.83
Severity: Normal Keywords:
Cc:

Description

GCC and Clang on Mac OS have a built-in __APPLE__ macro. Since I presume we don't need to compile on any other Darwin system except for Mac OS, let's use this built-in macro instead of manually-defined SYS_DARWIN and MACOSX.

MACOSX macro is also being used (but not defined) by miniupnp library. I've sent pull request for corresponding change in miniupnp, and also included it into attached patch.

Attachments (1)

5721-remove-sys_darwin-and-macosx-macros.patch (8.3 KB) - added by mike.dld 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by mike.dld

comment:1 Changed 8 years ago by mike.dld

  • Type changed from Bug to Enhancement

comment:2 Changed 8 years ago by jordan

livings124, this sounds good to me for 2.90

comment:3 Changed 8 years ago by livings124

We should wait until the changes are upstream to miniupnp

comment:4 Changed 8 years ago by jordan

miniupnp's already accepted the patch <https://github.com/miniupnp/miniupnp/commit/920845b1072e4c74c9918201258c1da9665989ba>, so the only holdup there is upstream hasn't done a release after the patch came out.

IMO since upstream's indicated their approval, I'm ok with patching our own copy locally in the interim.

comment:5 Changed 8 years ago by livings124

  • Milestone changed from None Set to 2.90
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.