Opened 7 years ago

Closed 6 years ago

#5722 closed Enhancement (fixed)

Use built-in _WIN32 macro instead of WIN32

Reported by: mike.dld Owned by:
Priority: Normal Milestone: 2.90
Component: Transmission Version: 2.83
Severity: Normal Keywords:
Cc:

Description

MinGW defines both _WIN32 and WIN32 (and may even be the only compiler doing so). Microsoft and Intel compilers only define _WIN32. Use the common one to eliminate the need in defining WIN32 explicitly.

3rd-party libraries:

Attachments (2)

5722-remove-win32-macro.patch (21.4 KB) - added by mike.dld 7 years ago.
5722-02-remove-win32-macro.patch (2.7 KB) - added by mike.dld 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by mike.dld

comment:1 Changed 7 years ago by mike.dld

Err, miniupnp commits date back to 2012.

comment:2 Changed 7 years ago by mike.dld

  • Type changed from Bug to Enhancement

comment:3 Changed 7 years ago by livings124

  • Milestone changed from None Set to 2.90
  • Resolution set to fixed
  • Status changed from new to closed

Changed 7 years ago by mike.dld

comment:4 Changed 7 years ago by mike.dld

  • Resolution fixed deleted
  • Status changed from closed to reopened

Due to recent changes in r14314, there're a couple more places to patch (patch attached). I'll update my #4160 patchset in a moment to take this ticket into account.

comment:5 Changed 6 years ago by mike.dld

  • Resolution set to fixed
  • Status changed from reopened to closed

Committed as r14348.

Note: See TracTickets for help on using tickets.