Opened 8 years ago
Closed 8 years ago
#5722 closed Enhancement (fixed)
Use built-in _WIN32 macro instead of WIN32
| Reported by: | mike.dld | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | 2.90 |
| Component: | Transmission | Version: | 2.83 |
| Severity: | Normal | Keywords: | |
| Cc: |
Description
MinGW defines both _WIN32 and WIN32 (and may even be the only compiler doing so). Microsoft and Intel compilers only define _WIN32. Use the common one to eliminate the need in defining WIN32 explicitly.
3rd-party libraries:
- dht: pull request
- event: already fixed on Jan 21 2014
- natpmp: pull request
- utp: pull request
- miniupnp: already fixed on Jan 21 2014, additional fix on Jan 25 2014, pull request
- curl: defines WIN32 by itself; seems like they also support compilation with Borland/Embarcadero compiler, which for some silly reason defines __WIN32__ and not _WIN32 (and I wonder who uses it anyway)
Attachments (2)
Change History (7)
Changed 8 years ago by mike.dld
comment:1 Changed 8 years ago by mike.dld
comment:2 Changed 8 years ago by mike.dld
- Type changed from Bug to Enhancement
comment:3 Changed 8 years ago by livings124
- Milestone changed from None Set to 2.90
- Resolution set to fixed
- Status changed from new to closed
Changed 8 years ago by mike.dld
comment:4 Changed 8 years ago by mike.dld
- Resolution fixed deleted
- Status changed from closed to reopened
comment:5 Changed 8 years ago by mike.dld
- Resolution set to fixed
- Status changed from reopened to closed
Committed as r14348.
Note: See
TracTickets for help on using
tickets.
Err, miniupnp commits date back to 2012.