Opened 6 years ago

Last modified 5 years ago

#5741 assigned Enhancement

Web UI: allow filter for trackerless torrents

Reported by: lolilolicon Owned by: jordan
Priority: Normal Milestone: 3.00
Component: Web Client Version: 2.84
Severity: Minor Keywords:
Cc:

Description

A patch to allow in the Web UI filter for trackerless torrents. It adds an "Trackerless" option under "All".

Attachments (2)

web_filter_trackerless.patch (1.8 KB) - added by lolilolicon 6 years ago.
web_filter_trackerless-v2.patch (2.0 KB) - added by lolilolicon 6 years ago.
update patch to handle the case when tracker is undefined

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by lolilolicon

Changed 6 years ago by lolilolicon

update patch to handle the case when tracker is undefined

comment:1 Changed 6 years ago by jordan

  • Milestone changed from None Set to 2.90
  • Owner set to jordan
  • Status changed from new to assigned

LGTM

comment:2 follow-up: Changed 6 years ago by jordan

Actually, two minor comments:

  1. In updateFilterSelect, shouldn't the "if (!this.filterTracker)" test come before the "if (this.filterTracker == "") test?
  1. I don't feel very strongly about this, but what do you think about "No Tracker" instead of "Trackerless" as the user-visible text? The former scans less jargonlike to my eyes.

comment:3 in reply to: ↑ 2 Changed 6 years ago by lolilolicon

Replying to jordan:

Actually, two minor comments:

  1. In updateFilterSelect, shouldn't the "if (!this.filterTracker)" test come before the "if (this.filterTracker == "") test?

This patch basically introduces the distinction between this.filterTracker === null (All) and this.filterTracker === "" (Trackerless). I think the logic is correct.

  1. I don't feel very strongly about this, but what do you think about "No Tracker" instead of "Trackerless" as the user-visible text? The former scans less jargonlike to my eyes.

It really depends on the user's realizing this is a filter for trackers. If you think about it, "All" should really be "Any"... in the same way, "None" is the correct text to display instead of "Trackerless". "No Tracker" is about the same as "Trackerless", but then shouldn't "All" be changed to "Any Tracker"?

comment:4 Changed 5 years ago by mike.dld

  • Milestone changed from 2.90 to 3.00
Note: See TracTickets for help on using tickets.