Opened 6 years ago

Closed 6 years ago

#5837 closed Bug (duplicate)

Stopping a torrent does not stop downloading from webseeds

Reported by: asaba90 Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 2.84
Severity: Normal Keywords: webseed
Cc:

Description

When I pause a torrent, it continues to download from webseeds, and I cannot stop it; unless I close and reopen transmission again. I am using Transmission 2.84 on Mac OS X.

Attachments (1)

fix_webseed_issues.patch (6.0 KB) - added by x190 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:2 Changed 6 years ago by benenator

Same behavior here, using Transmission 2.84 on Fedora 21. As mentioned in the comments of the tickets linked above, it appears that Transmission finishes downloading the "chunks" it's working on, instead of immediately stopping the download.

Expected behavior would be either:
a) Immediately cease downloading data for the paused torrent, regardless of source.
b) When the user pauses a torrent that is downloading content from a webseed, display a new message stating something to the effect of, "Pausing -- downloading from peers stopped. Download from webseed will stop after completion of current chunk", preferably with some sort of indication of how close the completion of that download is.

comment:3 Changed 6 years ago by x190

I have a basic patch that uses curl's CURLOPT_PROGRESSFUNCTION being tested and will post it soon.

Changed 6 years ago by x190

comment:4 follow-up: Changed 6 years ago by x190

Patch is for r14469. Downloading will stop on pausing the transfer, or if a webseed is sending bad pieces, or downloading to us without sending a 206 response code. Webseeds will also be disconnected on pause. This will stop the hangs and crashes that could result otherwise and should help us stay under curl's 1024 limit.

cfpp2p contributed many useful additions to the patch --- thanks!

Last edited 6 years ago by x190 (previous) (diff)

comment:5 in reply to: ↑ 4 Changed 6 years ago by cfpp2p

Replying to x190:

cfpp2p contributed many useful additions to the patch --- thanks!

Thank you! How is that updated patch coming that also fixes #5873 . The last I saw showed some pretty nice work. :-) It'd be nice to have that work out here for others to use and review.

comment:6 Changed 6 years ago by cfpp2p

Last edited 6 years ago by cfpp2p (previous) (diff)

comment:7 Changed 6 years ago by x190

  • Resolution set to duplicate
  • Status changed from new to closed

See #5923 for a patch.

Note: See TracTickets for help on using tickets.