Stopping a torrent does not stop downloading from webseeds

[asaba90]

When I pause a torrent, it continues to download from webseeds, and I cannot stop it; unless I close and reopen transmission again. I am using Transmission 2.84 on Mac OS X.

[cfpp2p]

ticket:4576#comment:13

ticket:4613#comment:3

ticket:1079

[benenator]

Same behavior here, using Transmission 2.84 on Fedora 21. As mentioned in the comments of the tickets linked above, it appears that Transmission finishes downloading the "chunks" it's working on, instead of immediately stopping the download.

Expected behavior would be either:
a) Immediately cease downloading data for the paused torrent, regardless of source.
b) When the user pauses a torrent that is downloading content from a webseed, display a new message stating something to the effect of, "Pausing -- downloading from peers stopped. Download from webseed will stop after completion of current chunk", preferably with some sort of indication of how close the completion of that download is.

[x190]

I have a basic patch that uses curl's CURLOPT_PROGRESSFUNCTION being tested and will post it soon.

[x190]

Patch is for r14469. Downloading will stop on pausing the transfer, or if a webseed is sending bad pieces, or downloading to us without sending a 206 response code. Webseeds will also be disconnected on pause. This will stop the hangs and crashes that could result otherwise and should help us stay under curl's 1024 limit.

cfpp2p contributed many useful additions to the patch --- thanks!

[cfpp2p]

Replying to x190:

cfpp2p contributed many useful additions to the patch --- thanks!

Thank you! How is that updated patch coming that also fixes #5873 . The last I saw showed some pretty nice work. :-) It'd be nice to have that work out here for others to use and review.

[x190]

See #5923 for a patch.