Opened 6 years ago

Last modified 6 years ago

#5903 new Bug

Transmissio - static analysis code

Reported by: dreck Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 2.84
Severity: Normal Keywords: cppcheck leak warnings portability performance overhead nullptr
Cc:

Description

I conducted an analysis tool cppcheck and found leaks in dependent libraries.

Revision r14470: Transmission/trunk

Since your project is open-source so you could be free to use in real-time https://scan.coverity.com/


libtransmission

[crypto-test.c:104]: (portability) Passing NULL after the last typed argument to a variadic function leads to undefined behaviour.
[crypto-test.c:105]: (portability) Passing NULL after the last typed argument to a variadic function leads to undefined behaviour.
[file-win32.c:920] -> [file-win32.c:927]: (performance) Variable 'ret' is reassigned a value before the old one has been used.
[handshake.c:220] -> [handshake.c:195]: (warning) Possible null pointer dereference: torrentHash - otherwise it is redundant to check it against null.
[file-win32.c:730]: (warning) Redundant code: Found a statement that begins with numeric constant.
[file-win32.c:731]: (warning) Redundant code: Found a statement that begins with numeric constant.
[file-win32.c:732]: (warning) Redundant code: Found a statement that begins with numeric constant.
[file-win32.c:1101]: (warning) Redundant code: Found a statement that begins with numeric constant.
[peer-mgr.c:2964]: (error) Possible null pointer dereference: rechoke
[tr-udp.c:140] -> [tr-udp.c:155]: (warning) Possible null pointer dereference: ipv6 - otherwise it is redundant to check it against null.
[utils-test.c:364]: (warning) Passing value -1 to sqrt() leads to implementation-defined result.
[utils.c:160]: (error) Common realloc mistake: 'buf' nulled but not freed upon failure
[variant.c:873]: (error) Common realloc mistake: 'stack' nulled but not freed upon failure
[variant.c:889]: (error) Common realloc mistake: 'stack' nulled but not freed upon failure

third-party/miniupnp

[miniwget.c:96]: (error) Common realloc mistake: 'header_buf' nulled but not freed upon failure
[miniwget.c:236]: (error) Common realloc mistake: 'content_buf' nulled but not freed upon failure
[miniwget.c:260]: (error) Common realloc mistake: 'content_buf' nulled but not freed upon failure
[upnpcommands.c:162]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[upnpcommands.c:462] -> [upnpcommands.c:496]: (warning) Possible null pointer dereference: intClient - otherwise it is redundant to check it against null.
[upnpcommands.c:463] -> [upnpcommands.c:503]: (warning) Possible null pointer dereference: intPort - otherwise it is redundant to check it against null.
[upnpcommands.c:160]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:176]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:216]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:264]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:271]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:278]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:329]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:388]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:432]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:529]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:560]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:567]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:653]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:741]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:789]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:836]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:918]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:960]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:999]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:1047]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[upnpcommands.c:1090]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.

third-party/libutp

[utp.cpp:920]: (warning) Assert statement calls a function which may have desired side effects: 'get'.
[utp.cpp:1247]: (warning) Assert statement calls a function which may have desired side effects: 'get'.
[utp.cpp:2064]: (warning) Assert statement calls a function which may have desired side effects: 'get'.
[utp.cpp:2110]: (warning) Assert statement calls a function which may have desired side effects: 'get'.
[utp.cpp:2265]: (warning) Assert statement calls a function which may have desired side effects: 'get'.
[utp.cpp:2440]: (warning) Assert statement calls a function which may have desired side effects: 'get'.
[utp.cpp:1150]: (error) Common realloc mistake: 'pkt' nulled but not freed upon failure
[templates.h:116]: (error) Common realloc mistake: 'mem' nulled but not freed upon failure
[utp.cpp:1227]: (warning) Assert statement calls a function which may have desired side effects: 'get'.

third-party/libevent

As a transparent replacement libevent, I can recommend libuv (doesn't leak)

[buffer_iocp.c:88]: (warning) Found calculation inside sizeof().
[buffer_iocp.c:104]: (warning) Found calculation inside sizeof().
[buffer_iocp.c:105]: (warning) Found calculation inside sizeof().
[buffer_iocp.c:114]: (warning) Found calculation inside sizeof().
[buffer_iocp.c:142]: (warning) Found calculation inside sizeof().
[buffer_iocp.c:185]: (warning) Found calculation inside sizeof().
[buffer_iocp.c:259]: (warning) Found calculation inside sizeof().
[buffer_iocp.c:287]: (warning) Found calculation inside sizeof().
[buffer.c:2729] -> [buffer.c:2733]: (performance) Variable 'res' is reassigned a value before the old one has been used.
[bufferevent.c:611]: (warning) Found calculation inside sizeof().
[buffer.c:2695]: (error) va_list 'aq' used before va_start() was called.
[buffer.c:2697]: (error) va_list 'aq' used before va_start() was called.
[buffer.c:2699]: (error) va_list 'aq' used before va_start() was called.
[bufferevent_async.c:116]: (warning) Found calculation inside sizeof().
[bufferevent_async.c:125]: (warning) Found calculation inside sizeof().
[bufferevent_async.c:134]: (warning) Found calculation inside sizeof().
[bufferevent_async.c:376]: (warning) Found calculation inside sizeof().
[bufferevent_async.c:422]: (warning) Found calculation inside sizeof().
[bufferevent_async.c:450]: (warning) Found calculation inside sizeof().
[bufferevent_async.c:491]: (warning) Found calculation inside sizeof().
[bufferevent_async.c:617]: (warning) Found calculation inside sizeof().
[bufferevent_filter.c:116]: (warning) Found calculation inside sizeof().
[bufferevent_filter.c:218]: (warning) Found calculation inside sizeof().
[bufferevent_filter.c:476]: (warning) Found calculation inside sizeof().
[buffer.c:280]: (warning) Found calculation inside sizeof().
[buffer.c:294]: (warning) Found calculation inside sizeof().
[buffer.c:297]: (warning) Found calculation inside sizeof().
[buffer.c:298]: (warning) Found calculation inside sizeof().
[buffer.c:312]: (warning) Found calculation inside sizeof().
[buffer.c:334]: (warning) Found calculation inside sizeof().
[buffer.c:341]: (warning) Found calculation inside sizeof().
[buffer.c:463]: (warning) Found calculation inside sizeof().
[buffer.c:550]: (warning) Found calculation inside sizeof().
[buffer.c:552]: (warning) Found calculation inside sizeof().
[buffer.c:638]: (warning) Found calculation inside sizeof().
[buffer.c:657]: (warning) Found calculation inside sizeof().
[buffer.c:748]: (warning) Found calculation inside sizeof().
[buffer.c:765]: (warning) Found calculation inside sizeof().
[buffer.c:775]: (warning) Found calculation inside sizeof().
[buffer.c:784]: (warning) Found calculation inside sizeof().
[buffer.c:807]: (warning) Found calculation inside sizeof().
[buffer.c:823]: (warning) Found calculation inside sizeof().
[buffer.c:824]: (warning) Found calculation inside sizeof().
[buffer.c:837]: (warning) Found calculation inside sizeof().
[buffer.c:838]: (warning) Found calculation inside sizeof().
[buffer.c:851]: (warning) Found calculation inside sizeof().
[buffer.c:852]: (warning) Found calculation inside sizeof().
[buffer.c:1003]: (warning) Found calculation inside sizeof().
[buffer.c:1013]: (warning) Found calculation inside sizeof().
[buffer.c:1075]: (warning) Found calculation inside sizeof().
[buffer.c:1079]: (warning) Found calculation inside sizeof().
[buffer.c:1080]: (warning) Found calculation inside sizeof().
[buffer.c:1131]: (warning) Found calculation inside sizeof().
[buffer.c:1213]: (warning) Found calculation inside sizeof().
[buffer.c:1575]: (warning) Found calculation inside sizeof().
[buffer.c:1664]: (warning) Found calculation inside sizeof().
[buffer.c:1703]: (warning) Found calculation inside sizeof().
[buffer.c:1722]: (warning) Found calculation inside sizeof().
[buffer.c:1723]: (warning) Found calculation inside sizeof().
[buffer.c:1749]: (warning) Found calculation inside sizeof().
[buffer.c:1833]: (warning) Found calculation inside sizeof().
[buffer.c:1849]: (warning) Found calculation inside sizeof().
[buffer.c:1850]: (warning) Found calculation inside sizeof().
[buffer.c:1864]: (warning) Found calculation inside sizeof().
[buffer.c:1865]: (warning) Found calculation inside sizeof().
[buffer.c:1886]: (warning) Found calculation inside sizeof().
[buffer.c:1911]: (warning) Found calculation inside sizeof().
[buffer.c:1928]: (warning) Found calculation inside sizeof().
[buffer.c:1941]: (warning) Found calculation inside sizeof().
[buffer.c:1944]: (warning) Found calculation inside sizeof().
[buffer.c:2040]: (warning) Found calculation inside sizeof().
[buffer.c:2407]: (warning) Found calculation inside sizeof().
[buffer.c:2477]: (warning) Found calculation inside sizeof().
[buffer.c:2508]: (warning) Found calculation inside sizeof().
[bufferevent_openssl.c:868] -> [bufferevent_openssl.c:870]: (warning) Possible null pointer dereference: wm - otherwise it is redundant to check it against null.
[bufferevent_pair.c:60]: (warning) Found calculation inside sizeof().
[bufferevent_openssl.c:182]: (warning) Found calculation inside sizeof().
[bufferevent_openssl.c:355]: (warning) Found calculation inside sizeof().
[bufferevent_openssl.c:999]: (warning) Found calculation inside sizeof().
[bufferevent_ratelim.c:455]: (warning) Found calculation inside sizeof().
[bufferevent_ratelim.c:608]: (warning) Found calculation inside sizeof().
[bufferevent_ratelim.c:724]: (warning) Found calculation inside sizeof().
[bufferevent_ratelim.c:908]: (warning) Found calculation inside sizeof().
[bufferevent_ratelim.c:937]: (warning) Found calculation inside sizeof().
[bufferevent_ratelim.c:1000]: (warning) Found calculation inside sizeof().
[bufferevent_sock.c:587]: (warning) Found calculation inside sizeof().
[bufferevent_sock.c:624]: (warning) Found calculation inside sizeof().
[epoll.c:421]: (warning) Found calculation inside sizeof().
[event.c:359]: (warning) Found calculation inside sizeof().
[event.c:775]: (warning) Found calculation inside sizeof().
[event.c:777]: (warning) Found calculation inside sizeof().
[event.c:782]: (warning) Found calculation inside sizeof().
[event.c:1205]: (warning) Found calculation inside sizeof().
[event.c:1249]: (warning) Found calculation inside sizeof().
[event.c:1276]: (warning) Found calculation inside sizeof().
[event.c:1336]: (warning) Found calculation inside sizeof().
[event.c:1474]: (warning) Found calculation inside sizeof().
[event.c:1803]: (warning) Found calculation inside sizeof().
[event.c:2031]: (warning) Found calculation inside sizeof().
[event.c:2052]: (warning) Found calculation inside sizeof().
[event.c:2064]: (warning) Found calculation inside sizeof().
[event.c:2227]: (warning) Found calculation inside sizeof().
[event.c:2242]: (warning) Found calculation inside sizeof().
[event.c:2323]: (warning) Found calculation inside sizeof().
[event.c:2426]: (warning) Found calculation inside sizeof().
[event.c:2427]: (warning) Found calculation inside sizeof().
[event.c:2523]: (warning) Found calculation inside sizeof().
[event.c:2579]: (warning) Found calculation inside sizeof().
[event.c:2593]: (warning) Found calculation inside sizeof().
[event.c:2888]: (warning) Found calculation inside sizeof().
[event.c:2923]: (warning) Found calculation inside sizeof().
[event.c:2925]: (warning) Found calculation inside sizeof().
[event.c:2935]: (warning) Found calculation inside sizeof().
[event.c:2936]: (warning) Found calculation inside sizeof().
[event.c:2937]: (warning) Found calculation inside sizeof().
[evport.c:454]: (error) Array 'evpd.ed_pending[8]' accessed at index 8, which is out of bounds.
[evmap.c:272]: (warning) Found calculation inside sizeof().
[evmap.c:347]: (warning) Found calculation inside sizeof().
[evmap.c:367]: (warning) Found calculation inside sizeof().
[evmap.c:372]: (warning) Found calculation inside sizeof().
[evmap.c:397]: (warning) Found calculation inside sizeof().
[evmap.c:401]: (warning) Found calculation inside sizeof().
[evmap.c:472]: (warning) Found calculation inside sizeof().
[evmap.c:571]: (warning) Found calculation inside sizeof().
[evmap.c:625]: (warning) Found calculation inside sizeof().
[evmap.c:641]: (warning) Found calculation inside sizeof().
[evmap.c:745]: (warning) Found calculation inside sizeof().
[evmap.c:746]: (warning) Found calculation inside sizeof().
[evmap.c:763]: (warning) Found calculation inside sizeof().
[evmap.c:764]: (warning) Found calculation inside sizeof().
[evmap.c:776]: (warning) Found calculation inside sizeof().
[evmap.c:777]: (warning) Found calculation inside sizeof().
[evmap.c:785]: (warning) Found calculation inside sizeof().
[evmap.c:789]: (warning) Found calculation inside sizeof().
[evmap.c:794]: (warning) Found calculation inside sizeof().
[evmap.c:795]: (warning) Found calculation inside sizeof().
[evdns.c:483]: (warning) Found calculation inside sizeof().
[evdns.c:516]: (warning) Found calculation inside sizeof().
[evdns.c:563]: (warning) Found calculation inside sizeof().
[evdns.c:575]: (warning) Found calculation inside sizeof().
[evdns.c:620]: (warning) Found calculation inside sizeof().
[evdns.c:652]: (warning) Found calculation inside sizeof().
[evdns.c:676]: (warning) Found calculation inside sizeof().
[evdns.c:708]: (warning) Found calculation inside sizeof().
[evdns.c:709]: (warning) Found calculation inside sizeof().
[evdns.c:735]: (warning) Found calculation inside sizeof().
[evdns.c:740]: (warning) Found calculation inside sizeof().
[evdns.c:808]: (warning) Found calculation inside sizeof().
[evdns.c:829]: (warning) Found calculation inside sizeof().
[evdns.c:862]: (warning) Found calculation inside sizeof().
[evdns.c:863]: (warning) Found calculation inside sizeof().
[evdns.c:1015]: (warning) Found calculation inside sizeof().
[evdns.c:1028]: (warning) Found calculation inside sizeof().
[evdns.c:1212]: (warning) Found calculation inside sizeof().
[evdns.c:1305]: (warning) Found calculation inside sizeof().
[evdns.c:1323]: (warning) Found calculation inside sizeof().
[evdns.c:1347]: (warning) Found calculation inside sizeof().
[evdns.c:1362]: (warning) Found calculation inside sizeof().
[evdns.c:1399]: (warning) Found calculation inside sizeof().
[evdns.c:1423]: (warning) Found calculation inside sizeof().
[evdns.c:1437]: (warning) Found calculation inside sizeof().
[evdns.c:1459]: (warning) Found calculation inside sizeof().
[evdns.c:2108]: (warning) Found calculation inside sizeof().
[evdns.c:2109]: (warning) Found calculation inside sizeof().
[evdns.c:2110]: (warning) Found calculation inside sizeof().
[evdns.c:2192]: (warning) Found calculation inside sizeof().
[evdns.c:2193]: (warning) Found calculation inside sizeof().
[evdns.c:2219]: (warning) Found calculation inside sizeof().
[evdns.c:2220]: (warning) Found calculation inside sizeof().
[evdns.c:2224]: (warning) Found calculation inside sizeof().
[evdns.c:2300]: (warning) Found calculation inside sizeof().
[evdns.c:2327]: (warning) Found calculation inside sizeof().
[evdns.c:2471]: (warning) Found calculation inside sizeof().
[evdns.c:2624]: (warning) Found calculation inside sizeof().
[evdns.c:2635]: (warning) Found calculation inside sizeof().
[evdns.c:2636]: (warning) Found calculation inside sizeof().
[evdns.c:2672]: (warning) Found calculation inside sizeof().
[evdns.c:2673]: (warning) Found calculation inside sizeof().
[evdns.c:2714]: (warning) Found calculation inside sizeof().
[evdns.c:2776]: (warning) Found calculation inside sizeof().
[evdns.c:2777]: (warning) Found calculation inside sizeof().
[evdns.c:2813]: (warning) Found calculation inside sizeof().
[evdns.c:2905]: (warning) Found calculation inside sizeof().
[evdns.c:2941]: (warning) Found calculation inside sizeof().
[evdns.c:2950]: (warning) Found calculation inside sizeof().
[evdns.c:3052]: (warning) Found calculation inside sizeof().
[evdns.c:3071]: (warning) Found calculation inside sizeof().
[evdns.c:3113]: (warning) Found calculation inside sizeof().
[evdns.c:3145]: (warning) Found calculation inside sizeof().
[evdns.c:3153]: (warning) Found calculation inside sizeof().
[evdns.c:3154]: (warning) Found calculation inside sizeof().
[evdns.c:3155]: (warning) Found calculation inside sizeof().
[evdns.c:3173]: (warning) Found calculation inside sizeof().
[evdns.c:3204]: (warning) Found calculation inside sizeof().
[evdns.c:3244]: (warning) Found calculation inside sizeof().
[evdns.c:3261]: (warning) Found calculation inside sizeof().
[evdns.c:3336]: (warning) Found calculation inside sizeof().
[evdns.c:3340]: (warning) Found calculation inside sizeof().
[evdns.c:3392]: (warning) Found calculation inside sizeof().
[evdns.c:3479]: (warning) Found calculation inside sizeof().
[evdns.c:4044]: (warning) Found calculation inside sizeof().
[evdns.c:4074]: (warning) Found calculation inside sizeof().
[evdns.c:4096]: (warning) Found calculation inside sizeof().
[evdns.c:4262]: (warning) Found calculation inside sizeof().
[evdns.c:4319]: (warning) Found calculation inside sizeof().
[evdns.c:4407]: (warning) Found calculation inside sizeof().
[evport.c:216]: (warning) Found calculation inside sizeof().
[evport.c:357]: (warning) Found calculation inside sizeof().
[evthread.c:183]: (warning) Found calculation inside sizeof().
[evthread.c:184]: (warning) Found calculation inside sizeof().
[evthread.c:199]: (warning) Found calculation inside sizeof().
[evthread.c:204]: (warning) Found calculation inside sizeof().
[evthread.c:215]: (warning) Found calculation inside sizeof().
[evthread.c:217]: (warning) Found calculation inside sizeof().
[evthread.c:230]: (warning) Found calculation inside sizeof().
[evthread.c:232]: (warning) Found calculation inside sizeof().
[evthread.c:234]: (warning) Found calculation inside sizeof().
[evthread.c:239]: (warning) Found calculation inside sizeof().
[evthread.c:258]: (warning) Found calculation inside sizeof().
[evthread.c:259]: (warning) Found calculation inside sizeof().
[evthread.c:325]: (warning) Found calculation inside sizeof().
[evthread.c:330]: (warning) Found calculation inside sizeof().
[evthread.c:349]: (warning) Found calculation inside sizeof().
[evthread.c:355]: (warning) Found calculation inside sizeof().
[evthread.c:356]: (warning) Found calculation inside sizeof().
[evthread.c:357]: (warning) Found calculation inside sizeof().
[evrpc.c:101]: (warning) Found calculation inside sizeof().
[evrpc.c:109]: (warning) Found calculation inside sizeof().
[evrpc.c:113]: (warning) Found calculation inside sizeof().
[evrpc.c:135]: (warning) Found calculation inside sizeof().
[evrpc.c:139]: (warning) Found calculation inside sizeof().
[evrpc.c:180]: (warning) Found calculation inside sizeof().
[evrpc.c:270]: (warning) Found calculation inside sizeof().
[evrpc.c:323]: (warning) Found calculation inside sizeof().
[evrpc.c:344]: (warning) Found calculation inside sizeof().
[evrpc.c:385]: (warning) Found calculation inside sizeof().
[evrpc.c:409]: (warning) Found calculation inside sizeof().
[evrpc.c:448]: (warning) Found calculation inside sizeof().
[evrpc.c:479]: (warning) Found calculation inside sizeof().
[evrpc.c:565]: (warning) Found calculation inside sizeof().
[evrpc.c:570]: (warning) Found calculation inside sizeof().
[evrpc.c:585]: (warning) Found calculation inside sizeof().
[evrpc.c:704]: (warning) Found calculation inside sizeof().
[evrpc.c:810]: (warning) Found calculation inside sizeof().
[evrpc.c:906]: (warning) Found calculation inside sizeof().
[evrpc.c:977]: (warning) Found calculation inside sizeof().
[evrpc.c:990]: (warning) Found calculation inside sizeof().
[evrpc.c:1005]: (warning) Found calculation inside sizeof().
[evrpc.c:1043]: (warning) Found calculation inside sizeof().
[evrpc.c:1045]: (warning) Found calculation inside sizeof().
[evrpc.c:1048]: (warning) Found calculation inside sizeof().
[http.c:4223] -> [http.c:4234]: (performance) Variable 'token' is reassigned a value before the old one has been used.
[http.c:1476]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[kqueue.c:196]: (warning) Found calculation inside sizeof().
[kqueue.c:270]: (warning) Found calculation inside sizeof().
[kqueue.c:308]: (warning) Found calculation inside sizeof().
[kqueue.c:428]: (warning) Found calculation inside sizeof().
[kqueue.c:458]: (warning) Found calculation inside sizeof().
[http.c:4185] -> [http.c:4296]: (warning) Possible null pointer dereference: cp - otherwise it is redundant to check it against null.
[http.c:4283] -> [http.c:4296]: (warning) Possible null pointer dereference: path - otherwise it is redundant to check it against null.
[http.c:4287] -> [http.c:4296]: (warning) Possible null pointer dereference: path - otherwise it is redundant to check it against null.
[http.c:208]: (warning) Found calculation inside sizeof().
[http.c:704]: (warning) Found calculation inside sizeof().
[http.c:1110]: (warning) Found calculation inside sizeof().
[http.c:1112]: (warning) Found calculation inside sizeof().
[http.c:1179]: (warning) Found calculation inside sizeof().
[http.c:1190]: (warning) Found calculation inside sizeof().
[http.c:1207]: (warning) Found calculation inside sizeof().
[http.c:1364]: (warning) Found calculation inside sizeof().
[http.c:1369]: (warning) Found calculation inside sizeof().
[http.c:2138]: (warning) Found calculation inside sizeof().
[http.c:2139]: (warning) Found calculation inside sizeof().
[http.c:2191]: (warning) Found calculation inside sizeof().
[http.c:2260]: (warning) Found calculation inside sizeof().
[http.c:2262]: (warning) Found calculation inside sizeof().
[http.c:2356]: (warning) Found calculation inside sizeof().
[http.c:2416]: (warning) Found calculation inside sizeof().
[http.c:2784]: (warning) Found calculation inside sizeof().
[http.c:3946]: (warning) Found calculation inside sizeof().
[http.c:4061]: (warning) Found calculation inside sizeof().
[http.c:4099]: (warning) Found calculation inside sizeof().
[http.c:4296]: (warning) Found calculation inside sizeof().
[listener.c:423]: (warning) Found calculation inside sizeof().
[poll.c:218]: (warning) Found calculation inside sizeof().
[poll.c:279]: (warning) Found calculation inside sizeof().
[poll.c:311]: (warning) Found calculation inside sizeof().
[poll.c:312]: (warning) Found calculation inside sizeof().
[select.c:246]: (warning) Found calculation inside sizeof().
[select.c:293]: (warning) Found calculation inside sizeof().
[signal.c:281]: (warning) Found calculation inside sizeof().
[signal.c:355]: (warning) Found calculation inside sizeof().
[test/regress.c:1944]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[test/regress.c:2286]: (error) Memory leak: mem
[test/regress_bufferevent.c:588] -> [test/regress_bufferevent.c:604]: (performance) Variable 'fake_listener' is reassigned a value before the old one has been used.
[test/regress_dns.c:370] -> [test/regress_dns.c:385]: (performance) Variable 'sock' is reassigned a value before the old one has been used.
[test/regress_http.c:2449] -> [test/regress_http.c:2453]: (performance) Variable 's' is reassigned a value before the old one has been used.
[test/regress_http.c:3257] -> [test/regress_http.c:3265]: (performance) Variable 'fd' is reassigned a value before the old one has been used.
[test/regress_http.c:3469] -> [test/regress_http.c:3474]: (warning) Possible null pointer dereference: state - otherwise it is redundant to check it against null.
[test/regress_http.c:1145]: (warning) Found calculation inside sizeof().
[test/regress_http.c:1158]: (warning) Found calculation inside sizeof().
[test/regress_http.c:1356]: (warning) Found calculation inside sizeof().
[test/regress_http.c:3474]: (warning) Found calculation inside sizeof().
[test/regress_http.c:3475]: (warning) Found calculation inside sizeof().
[test/regress_thread.c:326]: (error) Uninitialized struct member: cond.lock
[test/regress_thread.c:327]: (error) Uninitialized struct member: cond.cond
[test/tinytest_demo.c:49]: (warning) Unnecessary comparison of static strings.
[test/tinytest_demo.c:57]: (warning) Unnecessary comparison of static strings.
[test/tinytest_demo.c:62]: (warning) Unnecessary comparison of static strings.
[test/tinytest_demo.c:70]: (warning) Unnecessary comparison of static strings.
[test/tinytest_demo.c:73]: (warning) Unnecessary comparison of static strings.
[win32select.c:105]: (warning) Found calculation inside sizeof().
[win32select.c:106]: (warning) Found calculation inside sizeof().

Change History (2)

comment:1 Changed 6 years ago by mike.dld

  • Milestone changed from 2.90 to None Set

comment:2 Changed 6 years ago by mike.dld

Closed #5563 as duplicate of this ticket.

Note: See TracTickets for help on using tickets.