Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5913 closed Bug (invalid)

libutp for CMake-based builds r14484

Reported by: cfpp2p Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 2.84
Severity: Normal Keywords:
Cc:

Description

It doesn't seem to make sense to have r14484 since the most recent version of libutp from https://github.com/bittorrent/libutp already includes at line 1517 of utp_internal.cpp and the fix is already in transmission's third-party libutp utp.cpp

I don't understand the reason for the patch.

line 1517 of utp_internal.cpp

			// resends is a stack, and we're mostly interested in the top of it
			// if we're full, just throw away the lower half
			if (nr >= MAX_EACK - 2) {
				memmove(resends, &resends[MAX_EACK/2], MAX_EACK/2 * sizeof(resends[0]));
				nr -= MAX_EACK / 2;
			}

Change History (2)

comment:1 Changed 6 years ago by mike.dld

  • Resolution set to invalid
  • Status changed from new to closed

If you are talking about the most-most recent version, its API is incompatible with the one used in Transmission and there is #5888. I tried adjusting the code to use this new version and it kinda works but not as good. Will post the patch in #5888 in a couple of days with what I have. Revision used in CMake now is 7c4f19abdf which is the one right before those breaking changes (labeled "Merge BitTorrent libutp changes from uTorrent 3.4 (alpha)") were made.

As for the patch itself, CMake configuration is made in such a way that vanilla source code of 3rd-party libraries is being downloaded (instead of using what is in third-party/ subdirectory on SVN) and hence needs to be patched.

comment:2 Changed 6 years ago by cfpp2p

thanks for the explanation

Note: See TracTickets for help on using tickets.