Default configuration directory is PREFIX/local/share/locale when XDG_CONFIG_HOME is set.

[jyelloz]

In builds of the latest subversion code, if you have XDG_CONFIG_HOME set, the configuration directory is loaded from PREFIX/local/share/locale. This is due to an incorrect freeing of the configuration path, facilitated by the unfortunate practice of reassigning variables in any programming language.

It looks to be caused by a free after assignment which is not easily justified in any context: https://trac.transmissionbt.com/browser/trunk/libtransmission/platform.c?rev=14487&annotate=blame#L333

I have written a patch which I believe fixes the problem and avoids a memory leak when loading the environment variable value.

[jyelloz]

a patch to fix the bug

[x190]

---

[mike.dld]

Thanks for noticing this! Although I'd expect crash report upon accessing freed memory block but it seems that heap manager cuts us some slack here by not really freeing the memory just yet.

I've adjusted your patch a bit to get rid of compiler warning passing argument 1 of ‘tr_free’ discards ‘const’ qualifier from pointer target type (you should not pass pointers to constant data to free()) and make sure that tr_free() is only called with non-NULL argument. I've also made comparison against NULL explicit, that's my personal preference really but I think it makes code more readable. Committed as r14488.