Watch-dir: ".added" added to file name, but not added to queue, and nothing in Message Log

[sander]

Short

When you add a non-torrent file <>.torrent to the Watch-dir, it does get the extension ".added" (suggesting it was added), it does not get into queue (understable), but there is no message in Message Log (confusing / bug)

I would expect this from Transmission:

1) extension ".NOTadded" or ".fault" added

2) logging in Message Log about "not a torrent format"

Long

I was adding .torrent files to my Watch-dir. They got the extension ".added" added to their filename in that Watch-dir (so that looked good), but they were not added to the tranmission queue. Weird.

The transmission Help -> Message Log was not showing anything.

When starting transmission-gtk from the CLI, it said:

Message: Skipping unknown torrent "/home/sander/Downloads/torrent-scan-dir/blabla.torrent"

Aha ... "unknown torrent".

Then I discovered the blabla.torrent was not a correct .torrent format (it was a gzipped torrent).

OK, root cause found.

But I would expect this from Transmission:

1) extension ".NOTadded" or ".fault" added

2) logging in Message Log about "not a torrent format"

Tested on Ubuntu 15.04 with transmission-2.84+ transmission-trunk-r14535.tar.xz

[sander]

FWIW:

In transmission-2.84+/gtk/tr-core.c, after the lines:

          tr_ctorFree (ctor);
          g_message (_("Skipping unknown torrent \"%s\""), g_file_get_parse_name (file));

I added

          tr_logAddError ("File not in torrent format%s", g_file_get_parse_name(file));

and now I get an 'correct' error message in Help -> Message Log.