#5973 closed Bug (fixed)
transmission-2.84: fails to build on musl libc because of a missing header file.
| Reported by: | blueness | Owned by: | mike.dld |
|---|---|---|---|
| Priority: | Normal | Milestone: | 2.90 |
| Component: | Transmission | Version: | 2.84 |
| Severity: | Normal | Keywords: | |
| Cc: |
Description
libtransmission/transmission.h: add missing <sys/types.h>
transmission.h and several files including it, like bitfield.c and fdlimits.h make reference to ssize_t, off_t and other types defined in <sys/types.h> but never include the header. By including <sys/types.h> in transmission.h, the required type definitions are propagated to all files that need them.
Not including <sys/types.h> on glibc and uClibc systems does not pose a problem because of the way the headers stack in those C Standard Libraries, but on musl excluding <sys/types.h> leads to compile time failure.
For the POSIX specs, see
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html
Signed-of-by: Anthony G. Basile <blueness@…>
Attachments (1)
Change History (4)
Changed 7 years ago by blueness
comment:1 Changed 7 years ago by mike.dld
- Owner set to mike.dld
- Status changed from new to assigned
comment:2 Changed 7 years ago by mike.dld
- Milestone changed from None Set to 2.90
- Resolution set to fixed
- Status changed from assigned to closed
I tried building Transmission (trunk) in Gentoo/musl about a month ago and it succeeded with just a small redefinition warning (see r14543). The use of ssize_t was eliminated earlier in r14435. I consider this fixed, but please feel free to try out trunk yourself and see if there are any other issues.
comment:3 Changed 7 years ago by blueness
Heh, I'm the dude responsible for Gentoo/musl. I didn't test trunc, only the 2.84 release which was pushed out in Gentoo in July 2014. I'll check out trunc and see, but I'm sure you're. Sorry for the noise.
patch against version 2.84