Opened 6 years ago

Last modified 6 years ago

#5976 new Bug

Webseeds can be improperly disabled in webseed.c's web_response_func ()

Reported by: x190 Owned by: jordan
Priority: Normal Milestone: None Set
Component: libtransmission Version: 2.84
Severity: Normal Keywords: webseeds
Cc:

Description

Hitting pause, then resume, a few times in succession artificially disables webseeds for the session.

Change History (2)

comment:1 follow-up: Changed 6 years ago by x190

Patch to r14554:
libtransmission/webseed.c

-406          else if (++w->consecutive_failures >= MAX_CONSECUTIVE_FAILURES && !w->retry_tickcount)

+406          /* to allow for repeated button twiddling, don't increment w->consecutive_failures unless... */  
+407          else if (tor->isRunning && !tor->isStopping)
+408            {
+409              if (++w->consecutive_failures >= MAX_CONSECUTIVE_FAILURES && !w->retry_tickcount)
+410               /* now wait a while until retrying to establish a connection */
+411               ++w->retry_tickcount;
+412            }

Note: This patch is included in #5923.

Last edited 6 years ago by x190 (previous) (diff)

comment:2 in reply to: ↑ 1 Changed 6 years ago by cfpp2p

Replying to x190:

Note: This patch is included in #5923.

In my opinion the best is to apply full x190 patch #5923, since there are so many webseed related bugs.

Note: See TracTickets for help on using tickets.