Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#598 closed Bug (fixed)

1.00: OpenBSD compile & align errors

Reported by: charles Owned by: charles
Priority: High Milestone: 1.01
Component: libtransmission Version: 1.00
Severity: Normal Keywords:
Cc:

Description (last modified by charles)

from IRC:

10:33 < naddy> there is an alignment error in libtransmission/fastresume.c:parseProgress() that causes crashes on all archs that require strict aligment.

10:33 < naddy> const uint8_t * walk = buf;

10:33 < naddy> const tr_time_t * oldMTimes = (const tr_time_t *) walk;

10:33 < naddy> for( i=0; i<n; ++i ) {

10:33 < naddy> if ( curMTimes[i] == oldMTimes[i] )

10:33 < naddy> oldMTimes[i] is not guaranteed to be properly aligned. BOOM.

10:34 < naddy> this needs to use readBytes() or such

10:39 < naddy> libtransmission/natpmp.c needs to include <sys/types.h> before <sys/socket.h>, otherwise compilation will fail at least on openbsd.

Change History (4)

comment:1 Changed 14 years ago by charles

  • Description modified (diff)

comment:2 Changed 14 years ago by charles

  • Component changed from Transmission to libtransmission
  • Owner set to charles
  • Status changed from new to assigned

comment:3 Changed 14 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

1.0x: r4547 trunk: r4548

comment:4 Changed 14 years ago by charles

  • Summary changed from 1.00: openbsd compile & align errors to 1.00: OpenBSD compile & align errors
Note: See TracTickets for help on using tickets.