Opened 15 years ago

Closed 15 years ago

Last modified 12 years ago

#6 closed Defect (fixed)

"Reveal in Finder" not compatible with PathFinder

Reported by: agnomen.nm@… Owned by: somebody
Priority: Normal Milestone: Sometime
Component: Mac Client Version: 0.5
Severity: Normal Keywords:
Cc:

Description

Could the "Reveal in Finder" function be made compatible with PathFinder?? Some users don't use Finder.

Even if my PathFinder? has its identifier set to FNDRMACS (Finder) in PkgInfo?, it does not help.

Change History (4)

comment:1 Changed 15 years ago by transmission.bugs@…

{{{ - (void) revealFromMenu: (id) sender {

int row = [fTableView selectedRow]; if (row >= 0) {

[self finderReveal: [NSString stringWithFormat: @"%@/%@",

[NSString stringWithUTF8String: fStat[row].folder], [NSString stringWithUTF8String: fStat[row].info.name]]];

}

}

  • (void) finderReveal: (NSString *) path

{

NSString * string; NSAppleScript * appleScript; NSDictionary * error;

string = [NSString stringWithFormat:

@"tell application \"Finder\"\n"

" activate\n" " reveal (POSIX file \"%@\")\n" "end tell", path];

appleScript = [[NSAppleScript alloc] initWithSource: string]; if( ![appleScript executeAndReturnError: &error] ) {

printf( "finderReveal failed\n" );

} [appleScript release];

} }}}

This appears to be the current implementation of Transmission's "Reveal in Finder". It specifically accesses the Finder ("tell application Finder") through AppleScript?. I've done a little browsing and came up with this explanation of using NSWorkspace to implement such a feature. Presumably, that would be less dependant on the Finder.

comment:2 Changed 15 years ago by transmission.bugs@…

- (void) finderReveal: (NSString *) path {
	[[NSWorkspace sharedWorkspace] openURL: [NSURL fileURLWithPath: path]]
}

should probably do the job.

comment:3 Changed 15 years ago by titer

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [151]

comment:4 Changed 12 years ago by charles

  • Component changed from Transmission to Mac Client
Note: See TracTickets for help on using tickets.