Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6037 closed Enhancement (fixed)

[Mac] "Transfer Bandwidth" label unnecessarily overflows to a new line

Reported by: mattrajca Owned by: mike.dld
Priority: Normal Milestone: 2.90
Component: Mac Client Version: 2.84
Severity: Minor Keywords:
Cc:

Description

The "Transfer Bandwidth" label unnecessarily overflows to the next line. https://s3.amazonaws.com/f.cl.ly/items/2N0Q283p2e0G2C102o1s/Overflow.png

I attached a patch that:

  1. Lets Xcode 7 re-save the GlobalOptionsPopover?.xib file in its newer, slimmer XIB format.
  2. Keeps the "Transfer Bandwidth" label constrained to one line, as long as we don't hit the edge of the popover.

Screenshot after:

https://s3.amazonaws.com/f.cl.ly/items/2Z2t1K0U1X2n0J0T3d1q/After.png

Change History (8)

comment:1 Changed 6 years ago by mike.dld

Please attach the patch once more (not seeing it here).

comment:2 Changed 6 years ago by mattrajca

I get a Server Error when I try to upload the patch. Here it is on CloudApp?: http://cl.ly/2k1Y3M362J0M

comment:3 Changed 6 years ago by mike.dld

  • Owner changed from livings124 to mike.dld
  • Status changed from new to assigned

comment:4 Changed 6 years ago by mike.dld

First part committed in r14626, applied to all the XIBs. As second part will require autolayout, minimum OS X version was bumped to 10.7.

comment:5 Changed 6 years ago by mattrajca

This XIB already had Auto Layout constraints. The minimum deployment target of Transmission should probably just be bumped to 10.7. It seems like 90% of OS X users are using 10.9-10.11.

comment:6 Changed 6 years ago by mike.dld

Well, some other XIBs had autolayout enabled as well (by mistake I guess), but it wasn't actually being used: up until now we targeted OS X 10.6, so autolayout was a no-go.

comment:7 Changed 6 years ago by mike.dld

  • Milestone changed from None Set to 2.90
  • Resolution set to fixed
  • Status changed from assigned to closed
  • Version changed from 2.84+ to 2.84

Second part committed in r14635 with small adjustments. I've adjusted all the other languages as well; now waiting for when we drop 10.7 as 10.8 has base internationalization which should greatly simplify this by avoiding XIB duplication :)

See if everything displays as expected now (I've checked on 10.11 and 10.7). Thanks!

comment:8 Changed 6 years ago by mattrajca

Looks good, thanks.

Note: See TracTickets for help on using tickets.