Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6041 closed Enhancement (fixed)

Mac: Use AppKit's status light icons

Reported by: mattrajca Owned by: mike.dld
Priority: Normal Milestone: 2.90
Component: Mac Client Version: 2.84
Severity: Normal Keywords:
Cc:

Description

AppKit? provides status light icons we can use instead of providing our own. These look more in-line with the appearance of Yosemite+.

Before:

https://s3.amazonaws.com/f.cl.ly/items/1I1q2T3c0j0y0r0Z2o43/Image%202015-12-26%20at%209.02.22%20PM.png

After:

https://s3.amazonaws.com/f.cl.ly/items/411m3s3E1r0U1O0S1j40/Image%202015-12-26%20at%209.03.08%20PM.png

Attachments (2)

StatusIcons.diff (70.7 KB) - added by mattrajca 7 years ago.
StatusIcons2.diff (46.3 KB) - added by mattrajca 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by mattrajca

comment:1 Changed 7 years ago by mike.dld

  • Version changed from 2.84+ to 2.84

comment:2 follow-up: Changed 7 years ago by mike.dld

Something tells me that this doesn't hold for us (from NSImage documentation):

You should use these images as icons for toolbar items. The appearance of images can change between releases. If you use an image for its intended purpose (and not because of how it looks), your code should look correct from release to release.

I might partially agree on using it for port status indication (hmm, PORT_STATUS_ERROR and NSImageNameStatusPartiallyAvailable?), but certainly not for log message levels.

Changed 7 years ago by mattrajca

comment:3 in reply to: ↑ 2 Changed 7 years ago by mattrajca

Replying to mike.dld:

Something tells me that this doesn't hold for us (from NSImage documentation):

You should use these images as icons for toolbar items.

I'm pretty sure the comment on toolbar items doesn't apply to status images. Those used to be displayed in iChat's menu bar item (when it still existed).

The appearance of images can change between releases. If you use an image for its intended purpose (and not because of how it looks), your code should look correct from release to release.

I might partially agree on using it for port status indication (hmm, PORT_STATUS_ERROR and NSImageNameStatusPartiallyAvailable?), but certainly not for log message levels.

I agree. I uploaded a scaled-back patch that only uses the NSImageNameStatus* constants for port status indication in Preferences.

comment:4 Changed 7 years ago by mike.dld

  • Owner changed from livings124 to mike.dld
  • Status changed from new to assigned

comment:5 Changed 7 years ago by mike.dld

  • Milestone changed from None Set to 2.90
  • Resolution set to fixed
  • Status changed from assigned to closed

Committed as r14638, thanks.

comment:6 follow-up: Changed 7 years ago by livings124

FWIW, we should update the icons for the log too. We just need updated assets.

comment:7 in reply to: ↑ 6 Changed 7 years ago by mike.dld

Replying to livings124:

FWIW, we should update the icons for the log too. We just need updated assets.

I would agree. Where do we get new artwork from though? I presume most of the icons could be extracted from system resources (is this allowed?), except for the purple one.

Note: See TracTickets for help on using tickets.