Mac: Use AppKit's status light icons

[mattrajca]

AppKit? provides status light icons we can use instead of providing our own. These look more in-line with the appearance of Yosemite+.

Before:

After:

[mike.dld]

Something tells me that this doesn't hold for us (from NSImage documentation):

You should use these images as icons for toolbar items. The appearance of images can change between releases. If you use an image for its intended purpose (and not because of how it looks), your code should look correct from release to release.

I might partially agree on using it for port status indication (hmm, PORT_STATUS_ERROR and NSImageNameStatusPartiallyAvailable?), but certainly not for log message levels.

[mattrajca]

Replying to mike.dld:

Something tells me that this doesn't hold for us (from NSImage documentation):

You should use these images as icons for toolbar items.

I'm pretty sure the comment on toolbar items doesn't apply to status images. Those used to be displayed in iChat's menu bar item (when it still existed).

The appearance of images can change between releases. If you use an image for its intended purpose (and not because of how it looks), your code should look correct from release to release.

I might partially agree on using it for port status indication (hmm, PORT_STATUS_ERROR and NSImageNameStatusPartiallyAvailable?), but certainly not for log message levels.

I agree. I uploaded a scaled-back patch that only uses the NSImageNameStatus* constants for port status indication in Preferences.

[mike.dld]

Committed as r14638, thanks.

[livings124]

FWIW, we should update the icons for the log too. We just need updated assets.

[mike.dld]

Replying to livings124:

FWIW, we should update the icons for the log too. We just need updated assets.

I would agree. Where do we get new artwork from though? I presume most of the icons could be extracted from system resources (is this allowed?), except for the purple one.