Opened 6 years ago

Closed 6 years ago

#6042 closed Enhancement (fixed)

Mac: Removed dead code paths

Reported by: mattrajca Owned by: livings124
Priority: Normal Milestone: 2.90
Component: Mac Client Version: 2.84
Severity: Normal Keywords:
Cc:

Description

Removed dead code paths now that the deployment target is 10.7+.

Attachments (2)

DeadCode.diff (8.0 KB) - added by mattrajca 6 years ago.
CompleteLionDeadCode.diff (41.2 KB) - added by mattrajca 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by mattrajca

comment:1 Changed 6 years ago by mike.dld

Doesn't look complete, I'd through away isOnLionOrBetter from NSApplication additions as well, which reveals whole lot more checks for Lion :) Same file (NSApplicationAdditions.h) also defines NSPopoverLion and NSDataDetectorLion which could now be removed and replaced in code with just NSPopover and NSDataDetector respectively.

comment:2 Changed 6 years ago by mattrajca

I was going to send out smaller, incremental patches so it's easier to review.

comment:3 Changed 6 years ago by mike.dld

If you feel more comfortable this way... I'd still prefer to have all the patches right away than getting them one by one and hoping they won't stop coming in the middle (no offence, it's me being pragmatic). Also, splitting the change so that each patch has more meaning behind it than just being small enough for review might be a good idea.

comment:4 Changed 6 years ago by mike.dld

Wow, hopefully I didn't spook you with comment:3, wasn't my intention :)

Changed 6 years ago by mattrajca

comment:5 Changed 6 years ago by mattrajca

I'm back! Attached is the diff with all the < 10.7 dead code removed.

comment:6 Changed 6 years ago by mike.dld

  • Milestone changed from None Set to 2.90
  • Resolution set to fixed
  • Status changed from new to closed

Committed as r14662 with a few additions. Thanks!

Note: See TracTickets for help on using tickets.