Opened 7 years ago
Closed 7 years ago
#6122 closed Bug (duplicate)
Drag/Drop links not working in web client (using undefined `contains` method)
Reported by: | nickchristensen | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | None Set |
Component: | Web Client | Version: | 2.92 |
Severity: | Normal | Keywords: | |
Cc: |
Description
Problem
Simply dragging a link over the document fires hundreds of errors in the js console, and dropping the link triggers the same error.
The code for accepting dropped links (added in [12475]) defined at:
- source:trunk/web/javascript/transmission.js#L552
- source:/trunk/web/javascript/transmission.js#L576
calls a contains method on an array, which doesn't exist.
Proposed Solution
Swapping this method call with a new (and fairly unsupported) includes method works perfectly on newer browsers. The MDN page also shows a well-written polyfill to support older browsers.
I'd love to contribute code for this, if it would help.
Change History (1)
comment:1 Changed 7 years ago by mike.dld
- Resolution set to duplicate
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Thanks for the report. I think it would be better to fix existing patch in #5949 (which uses indexOf instead of contains already).