Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#687 closed Enhancement (fixed)

GNOME HIG fixes for Details dialog

Reported by: LucaFerretti Owned by: charles
Priority: Normal Milestone: 1.10
Component: GTK+ Client Version: 1.04
Severity: Minor Keywords:
Cc:

Description

Here is a patch with some changes to Details dialog in order to make it more GNOME HIG compliant.

Changes:

  • hig.c - change the group indentation from 18 to 12 pixel
  • fix border (12) and spacing between notebook and buttonbox
  • Remove access key from tabs headers
  • use sentence capitalization for labels (were applicable)
  • move the measure unit after the spinbox
  • BONUS: use Q_() instead of _() for table headers in Files tab. Reason: "Download" is not a simple word to translate, better specify it's a yes/no checkbox here

Missing stuff in attached patch but needed by HIG:

  • Tables should have a label above with access key.
  • "Connect at maximum to:" should have an access key to focus the associated spinbox.
  • "Comment:" label in Info->Torrent Informatio could be vertically top-aligned and should have an access key to focus the text area.
  • Completeness graph in Activity page could be moved to its own group (like Piece Availability in Peers tab)
  • the border around the table in Files section should be 12 pixels

Attachments (1)

Transmission-HIG-for-details-dialog.diff (10.9 KB) - added by LucaFerretti 14 years ago.
The proposed patch

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by LucaFerretti

The proposed patch

comment:1 Changed 14 years ago by LucaFerretti

Note: there is something wrong somewhere. Launching from terminal I've this warning:

(transmission:29173): Gtk-WARNING : A floating object was finalized. This means that someone called g_object_unref() on an object that had only a floating reference; the initial floating reference is not owned by anyone and must be removed with g_object_ref_sink().

comment:2 Changed 14 years ago by charles

  • Milestone changed from None Set to 1.10
  • Status changed from new to assigned
  • Version changed from 1.03 to 1.04

I've committed the patch to trunk (r4927) for 1.10.

If you want to make a subset of the patch for everything that doesn't break the string freeze, I can put that in 1.05.

I'm not seeing the Gtk-WARNING that you're seeing. Try running Transmission in gdb and setting a breakpoint for g_log to see where it's coming from. Note, Transmission seems to run better in gdb if "handle SIGPIPE nostop noprint nopass" is set.

comment:3 Changed 14 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

completed in r4961 and r4962:

  • "Connect at maximum to:" should have an access key to focus the associated spinbox.
  • the border around the table in Files section should be 12 pixels
  • "Comment:" label in Info->Torrent Information could be vertically top-aligned and should have an access key to focus the text area.
  • Completeness graph in Activity page could be moved to its own group (like Piece Availability in Peers tab)

comment:4 Changed 14 years ago by charles

  • Severity changed from Normal to Minor
Note: See TracTickets for help on using tickets.