Opened 14 years ago

Closed 14 years ago

#748 closed Bug (fixed)

Remove torrent confirmation not following HIG

Reported by: infernux Owned by: charles
Priority: Normal Milestone: 1.10
Component: GTK+ Client Version: 1.06
Severity: Normal Keywords:
Cc:

Description

There are various things wrong with the "Remove torrent" confirmation window:

  • Should not have a window title
  • font of primary text is too small
  • "...torrent(s)" should be "torrent" or "torrents" depending on how many torrents are selected
  • The dialog should not change (display additional text) if the checkbox is active.
  • Don't use "yes" and "no"... better use "cancel" (with gtk-cancel icon) and "remove" (gtk-remove icon).
  • Perhaps the checkbox should be replaced by a simple "Also remove data" button (with a gtk-delete icon) at the bottom?

For the the official HIG words, see [1] (especially the section about "Confirmation Alerts".

[1] http://developer.gnome.org/projects/gup/hig/draft_hig_new/windows-alert.html

Change History (3)

comment:1 follow-up: Changed 14 years ago by charles

  • Component changed from Transmission to GTK+ Client
  • Milestone changed from None Set to 1.10
  • Owner set to charles
  • Status changed from new to assigned

I agree aobut the window title, the text size, the pluralization, the additional text, and the yes/no. These are all good ideas!

I'm not sure that I like having a dialog button for "also remove data" at the bottom. With the checkbox it's a two-step process, so someone's less likely to delete data when they didn't mean to. If we add a delete button the user might click it by accident.

comment:2 in reply to: ↑ 1 Changed 14 years ago by infernux

I'm not sure that I like having a dialog button for "also remove data" at the bottom. With the checkbox it's a two-step process, so someone's less likely to delete data when they didn't mean to. If we add a delete button the user might click it by accident.

Yes... I actually asked the guys on #tango, and while the third button would be the more correct thing most seemed to agree that having the checkbox would be better in this case.

comment:3 Changed 14 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

r5180

if we have a separate dialog for "remove" and "delete", we can better tailor the text AND dialog style for the action AND hav remove/delete buttons without losing the two-step process...

Note: See TracTickets for help on using tickets.