Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#757 closed Enhancement (fixed)

Group specific location settings

Reported by: sanmarcos Owned by: livings124
Priority: Normal Milestone: 1.60
Component: Mac Client Version: 1.06
Severity: Normal Keywords: groups
Cc: ciaran

Description (last modified by livings124)

Not implemented with this ticket
It would be nice if groups could have specific speed settings, for example, the "Public" group could be set to seed to 1.0 ratio, the "TrackerX" group to 3.0 and to seed at 100kbps.

These settings would be applied when a group is set to a torrent.

Mostly implemented with this ticket
Another thing to look into would be to have download folders for each group. If a download was in the Music group, let's say, it would automatically download to the Music sub-folder in the Downloads folder, Movies into a Movies sub-folder, etc. This could be extended to the "keep incomplete files in:" feature. It *could* also be extended to the "watch for torrent files in:" feature, where if the name of the sub-folder in which the torrent is found matches the name of a group, the torrent can automatically be added to that group and downloaded to the appropriate sub-folder.

This would be very useful for power users that deal with a lot of different trackers.

Attachments (6)

Group settings.jpg (220.3 KB) - added by sanmarcos 13 years ago.
See what I mean here
preference panel groups mockup 3.png (69.3 KB) - added by persept 13 years ago.
I added a mockup of what it might look like to have the groups preferences in the main preferences window. In it you would be able to set trackers whose torrents would automatically join a specific group and choose to automatically save to a certain directory. Other options could always be added, this is only a mockup.
group-locations.patch (43.7 KB) - added by ciaran 12 years ago.
Patch to allow per-group download locations, when a group is assigned to a torrent in the add window
crash-fix.patch (1.4 KB) - added by ciaran 12 years ago.
Fixes a crash when attempting to select a custom download path
ui-fix.patch (459 bytes) - added by ciaran 12 years ago.
The group location popup was not disabled if the initial location sheet was dismissed
group-selection-behaviour.patch (941 bytes) - added by ciaran 12 years ago.
When changing the selected group in the add torrent window, the download location will be reverted to the default if the current location is that of the original group's and the new group has no location set

Download all attachments as: .zip

Change History (25)

Changed 13 years ago by sanmarcos

See what I mean here

comment:1 Changed 13 years ago by sanmarcos

  • Milestone changed from None Set to 1.10

Also, I just noticed on the Add torrent window, it says ~/Downloads. You might consider removing that ~/ for non UNIX experienced Users. Maybe just leave it out, or see how the finder path bar does it.

comment:2 Changed 13 years ago by livings124

  • Priority changed from Normal to Low
  • Severity changed from Normal to Minor

Don't set milestones unless you're going to submit a patch.

comment:3 Changed 13 years ago by livings124

  • Milestone changed from 1.10 to None Set

comment:4 Changed 13 years ago by charles

  • Component changed from Transmission to Mac Client
  • Owner set to livings124

comment:5 Changed 13 years ago by sanmarcos

It would also be nice to have Groups be able to specify Finder Labels for the files the torrent downloads.

comment:6 Changed 13 years ago by sanmarcos

  • Version changed from 1.06 to 1.22

This feature should be implemented first by adding a Download location to the groups.

It seems pretty easy to do, just add it to the groups window, and when the Combo box is changed on the torrent added dialog, set the Path from the group.

Is there a XIB file for the Torrent Added dialog?

comment:7 Changed 13 years ago by livings124

  • Version changed from 1.22 to 1.06

Changed 13 years ago by persept

I added a mockup of what it might look like to have the groups preferences in the main preferences window. In it you would be able to set trackers whose torrents would automatically join a specific group and choose to automatically save to a certain directory. Other options could always be added, this is only a mockup.

comment:8 Changed 12 years ago by livings124

  • Summary changed from Group specific speed/location settings settings to Group specific speed/location settings

Changed 12 years ago by ciaran

Patch to allow per-group download locations, when a group is assigned to a torrent in the add window

comment:9 Changed 12 years ago by livings124

  • Status changed from new to assigned
  • Summary changed from Group specific speed/location settings to Group specific location settings

The speed settings can't be implemented until groups are in libtransmission. Changing the summary to reflect that.

comment:10 Changed 12 years ago by livings124

  • Milestone changed from None Set to 1.50

comment:11 Changed 12 years ago by livings124

  • Priority changed from Low to Normal
  • Severity changed from Minor to Normal

comment:12 Changed 12 years ago by ciaran

  • Cc ciaran added

comment:13 Changed 12 years ago by livings124

  • Description modified (diff)

comment:14 Changed 12 years ago by livings124

  • Resolution set to fixed
  • Status changed from assigned to closed

[7210] has the first go of implementing different locations for each group when added through the options window.

For other parts of this ticket, please open new tickets.

comment:15 Changed 12 years ago by sanmarcos

Thank you so much. Please see bug #1541 for the speed settings ticket.

Changed 12 years ago by ciaran

Fixes a crash when attempting to select a custom download path

Changed 12 years ago by ciaran

The group location popup was not disabled if the initial location sheet was dismissed

Changed 12 years ago by ciaran

When changing the selected group in the add torrent window, the download location will be reverted to the default if the current location is that of the original group's and the new group has no location set

comment:16 Changed 12 years ago by livings124

patches in [7212]

comment:17 Changed 12 years ago by Waldorf

  • Resolution fixed deleted
  • Status changed from closed to reopened

I have a few issues with the current implementation: It moves the file before the transfere begins.

This causes:

  • Time Machine should not back-up those folders. eg. Many will have a music group and set the location to ~/Music, they will want it to be backed-up.
  • More corrupt files. The same reason as why T doesn't have support for scripts when a transfer ends.
  • It doesn't honour my incomplete folder. Logically, but I still like it to.

Conclusion: I really prefer it to Move on Completion. If not by default, then by option.

comment:18 Changed 12 years ago by livings124

  • Resolution set to fixed
  • Status changed from reopened to closed

Waldorf: I don't know what you're talking about. The current behavior is to set the location when adding, which is exactly the same as if you changed it yourself in the add window. It should not cause any of those issues (and if it does, it is not part of this ticket).

comment:19 Changed 12 years ago by livings124

  • Milestone changed from 1.50 to 1.60
Note: See TracTickets for help on using tickets.