Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#769 closed Bug (fixed)

Close/Remove torrent does not ask for confirmation (trunk r5209)

Reported by: infernux Owned by: charles
Priority: Normal Milestone: 1.10
Component: GTK+ Client Version:
Severity: Normal Keywords:
Cc:

Description

With trunk of today, the remove (close) action does no longer ask for confirmation. I also get this error on the console which seems to be related:

(transmission:17893): GLib-GObject-CRITICAL : g_object_unref: assertion `G_IS_OBJECT (object)' failed

Change History (4)

comment:1 Changed 14 years ago by infernux

  • Component changed from Transmission to GTK+ Client
  • Owner set to charles

comment:2 Changed 14 years ago by charles

  • Milestone changed from None Set to 1.10
  • Status changed from new to assigned
  • Summary changed from Close/Remove torrent does not ask for confirmation to Close/Remove torrent does not ask for confirmation (trunk r5209)
  • Version 1.06 deleted

r5215 silences the warnings

comment:3 Changed 14 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

r5216 (actions.c dialogs.c dialogs.h main.c ui.h): when removing a torrent, prompt for confirmation if any of the following is true: (a) the torrent is incomplete, (b) the torrent is connected to peers, (c) the user is also deleting the downloaded files.

infernux: I'd like you to look over my shoulder on these changes please, particularly in the dialog strings... I think I've made them pretty clear, short, to-the-point, and easy to translate, and would appreciate feedback on them.

comment:4 Changed 14 years ago by infernux

Thanks for the quick fixes today!

I'll review the dialogs and send you a mail with comments.

Note: See TracTickets for help on using tickets.