Opened 14 years ago

Closed 14 years ago

#889 closed Enhancement (invalid)

[PATCH] Mute during time period (or: play as system sounds)

Reported by: Malesca Owned by: livings124
Priority: Normal Milestone: None Set
Component: Mac Client Version: 1.11
Severity: Normal Keywords:
Cc:

Description

I would like to mute the Transmission sounds (on download/upload completion) during the night, so I'm not awoken by a completed download.

I don't, however, want to mute the computer altogether, since I sometimes will want to e.g. watch a movie late.

I experimented with setting the system sound volume to 0, but this doesn't affect the Transmission sounds. I'm not sure if that should be considered a bug or not – I'm not familiar with the convention here.

I would suggest either fixing Transmission to play those sounds as system sounds, or to add functionality to Transmission to mute its sounds during a time period. You can set speed limits during a period already, so there is likely code for most of this already.

Change History (10)

comment:1 Changed 14 years ago by charles

  • Component changed from Transmission to Mac Client
  • Owner set to livings124

comment:2 Changed 14 years ago by Malesca

  • Summary changed from Mute during time period (or: play as system sounds) to [PATCH] Mute during time period (or: play as system sounds)

I made a patch. Diff (that perhaps contains more than it should, from the XIB? I haven't done patches against XIBs before): http://henrik.nyh.se/filer/mute_sounds.diff (too big for Trac) Without the XIB changes, for reference: http://henrik.nyh.se/filer/mute_sounds_without_xib.diff

Also made a screenshot of the preference setting: http://henrik.nyh.se/filer/mute_sounds.png

I've played a little with Cocoa before, but I'm far from experienced with it, so this might not be the best solution.

comment:3 Changed 14 years ago by Malesca

Some things I didn't do because I didn't know the proper way to:

  • Localization
  • Possibly disable the checkbox and fields if neither the download sound nor the upload sound is activated
  • Possibly refactor the code a little to get rid of the duplication of datetime comparison code here and in the rate limiting

comment:4 follow-up: Changed 14 years ago by livings124

  • Resolution set to wontfix
  • Status changed from new to closed

I really, REALLY appreciate you writing this patch, and in the future I hope you can contribute more. Unfortunately, this feature is a bit bloaty (won't be used by > 99% of the users, and can be argued that any app should have this functionality). I really don't want to turn away any contribution, but I honestly can't justify putting this in.

comment:5 in reply to: ↑ 4 Changed 14 years ago by Malesca

Replying to livings124:

I really, REALLY appreciate you writing this patch, and in the future I hope you can contribute more. Unfortunately, this feature is a bit bloaty (won't be used by > 99% of the users, and can be argued that any app should have this functionality). I really don't want to turn away any contribution, but I honestly can't justify putting this in.

No worries. I like that you guys fight feature creep and realized from the start you might not accept this. Was fun to play with Cocoa again anyway.

How about the other suggestion in this ticket, playing the sounds as system sounds so they can be muted by external scripts that turn down the system volume? My googling hasn't turned up any information on how to do this, but the fact that you can mute system sounds suggests it can be done.

comment:7 Changed 14 years ago by Malesca

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Reopening the ticket to get a response -- seems the timeline doesn't show comments on closed tickets, nor do you seem to get e-mails at ticket activity.

comment:8 Changed 14 years ago by livings124

That is a very good idea indeed.

comment:9 Changed 14 years ago by livings124

That API appears to be deprecated on 10.5. It would be a good idea to find what the current equivalent is.

comment:10 Changed 14 years ago by livings124

  • Resolution set to invalid
  • Status changed from reopened to closed

There's not straightforward api available in 10.5 for this. If someone can find one, please reopen.

Note: See TracTickets for help on using tickets.