Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#958 closed Enhancement (fixed)

Quick Look Integration

Reported by: Waldorf Owned by: livings124
Priority: Normal Milestone: 1.30
Component: Mac Client Version: 1.21
Severity: Normal Keywords:
Cc: Waldorf

Description

Since Cyberduck now comes with QuickLook? Build-in, I though I'd give implementing it a try. Attached are all the changes needed to allow QL, with 'slideshow' and zooming from the FileOutlineView?.

The QuickLook?.h header file should be included in the project, to calm the compiler. It checks for availability of QL so it should (meaning not tested) not break on Tiger.

Oh, I did include a check wether a file is complete. If not, it will not open the QuickLook? window. So, even if multiple files are selected, folders and incomplete files will be skipped.

Recourses:
http://macresearch.org/cocoa-tutorial-image-kit-cover-flow-and-quicklook-doing-things-we-shouldnt-are-too-fun-resist
http://ciaranwal.sh/2007/12/07/quick-look-apis
Cyberduck's code

Attachments (4)

QuickLook.h (3.2 KB) - added by Waldorf 14 years ago.
The header file. Just include it in the project somewhere…
ql.diff (7.5 KB) - added by Waldorf 14 years ago.
Now QL folders, closes when info window and when selecting non complete files (v2)
ql2.diff (7.7 KB) - added by Waldorf 14 years ago.
Same as previous (ql.diff), only sending the inspector close msg from its delegate to the fileOutlineController
ql_keywindow_fix.diff (1.7 KB) - added by Waldorf 14 years ago.
Return of the makeKeyWindow

Download all attachments as: .zip

Change History (13)

Changed 14 years ago by Waldorf

The header file. Just include it in the project somewhere...

comment:1 Changed 14 years ago by Waldorf

I did the implementation in FileOutlineController?, however it could be implemented just as easy in FileOutlineView? (10 sec with copy/paste). The difference would be that the keyDown does not need to be forwarded to the delegate, but it makes listening to outlineViewSelectionDidChange and updating the QL window more complicated.

comment:2 Changed 14 years ago by chinstrap

Tested patch. Worked for me. Very slick.

comment:3 Changed 14 years ago by Waldorf

Oh, coded on r5856.

Changed 14 years ago by Waldorf

Now QL folders, closes when info window and when selecting non complete files (v2)

Changed 14 years ago by Waldorf

Same as previous (ql.diff), only sending the inspector close msg from its delegate to the fileOutlineController

comment:4 Changed 14 years ago by Waldorf

note: Animation types: 0 = none; 1 = fade; 2 = zoom

comment:5 Changed 14 years ago by livings124

[5862] Thanks!

comment:6 Changed 14 years ago by livings124

  • Resolution set to fixed
  • Status changed from new to closed

Changed 14 years ago by Waldorf

Return of the makeKeyWindow

comment:7 Changed 14 years ago by Waldorf

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Quick Look from within the Inspector to Quick Look Integration

Fix for the makeKeyWindow

comment:8 Changed 14 years ago by livings124

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:9 Changed 14 years ago by charles

  • Version set to 1.21
Note: See TracTickets for help on using tickets.